Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isdir checking inside of SFTP class #1147

Closed
wants to merge 1 commit into from
Closed

Fix isdir checking inside of SFTP class #1147

wants to merge 1 commit into from

Conversation

@ikalnytskyi
Copy link

@ikalnytskyi ikalnytskyi commented Jun 24, 2014

We have to use stat instead of lstat inside isdir method, since the first one returns True even for symlinks to folders.

The fix is very important when we need to download some folder that contains a symlink to another one.

We have to use `stat` instead of `lstat` inside `isdir` method, since
the first one returns `True` even for symlinks to folders.

The fix is very important when we need to download some folder that
contains a symlink to another one.
openstack-gerrit pushed a commit to openstack-archive/fuel-web that referenced this issue Jun 26, 2014
Shootgun uses a fabric.api.get method to download some folder from the
remote host. Unfortunately, this method has a bug and fails when we
trying to download a folder that contains a symlink to another one.

So we need to patch fabric api to prevent us from such falls. The issue
with fabric api is that it recognize all symlinks as a file. As a result
we fails when trying to download a folder (pointed by a symlink)  as
a file.

The patch was proposed to the fabric master branch and can be reviewed
here:

    fabric/fabric#1147

Closes-Bug: #1318514
Closes-Bug: #1323436

Change-Id: Ic2ae889337e5da15bbdf83338b8e8d5d913aeb63
@bitprophet bitprophet added Bug and removed Contrib labels Aug 4, 2014
@bitprophet bitprophet closed this in 7cbd561 Aug 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants