Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added use_sudo as a kwarg to the reboot function. #1161

Merged
merged 1 commit into from Apr 8, 2016
Merged

Added use_sudo as a kwarg to the reboot function. #1161

merged 1 commit into from Apr 8, 2016

Conversation

@btv
Copy link

@btv btv commented Jul 17, 2014

This PR is to add a kwarg to reboot to allow run instead of just sudo within the reboot function.

No test written as no test currently exists for reboot.

Output from pylint is:

pylint2 -E operations.py 
No config file found, using default configuration
************* Module fabric.operations
E:827,54: Instance of 'list' has no 'endswith' member (but some types could not be inferred) (maybe-no-member)
E:828,53: Instance of 'list' has no 'endswith' member (but some types could not be inferred) (maybe-no-member)

Which isn't related to my change (though after looking at the code I can see why pylint is confused).

@btv
Copy link
Author

@btv btv commented Jan 22, 2015

@bitprophet
Sorry, I totally spaced on this commit. For the "Needs changelog/docs" flag, is there any documentation for adding to the docs?

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Jan 28, 2015

I really should split that label up, in this case it just meant "there's no changelog entry yet". Changelog is in sites/www/changelog.rst if you want to take a stab, otherwise I will add an entry when I merge. Gonna throw this into next feature release since this is pretty small. Thanks!

@bitprophet bitprophet added this to the 1.11 milestone Jan 28, 2015
@bitprophet bitprophet changed the title Added use_sudo as a kwarg to the sudo function. Added use_sudo as a kwarg to the reboot function. Jan 28, 2015
@bitprophet bitprophet merged commit 648457d into fabric:master Apr 8, 2016
1 check passed
1 check passed
@bitprophet
continuous-integration/travis-ci The Travis CI build passed
Details
bitprophet added a commit that referenced this pull request Apr 8, 2016
bitprophet added a commit that referenced this pull request Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants