Added use_sudo as a kwarg to the reboot function. #1161

Merged
merged 1 commit into from Apr 8, 2016

Projects

None yet

2 participants

@btv
btv commented Jul 17, 2014

This PR is to add a kwarg to reboot to allow run instead of just sudo within the reboot function.

No test written as no test currently exists for reboot.

Output from pylint is:

pylint2 -E operations.py 
No config file found, using default configuration
************* Module fabric.operations
E:827,54: Instance of 'list' has no 'endswith' member (but some types could not be inferred) (maybe-no-member)
E:828,53: Instance of 'list' has no 'endswith' member (but some types could not be inferred) (maybe-no-member)

Which isn't related to my change (though after looking at the code I can see why pylint is confused).

@btv
btv commented Jan 22, 2015

@bitprophet
Sorry, I totally spaced on this commit. For the "Needs changelog/docs" flag, is there any documentation for adding to the docs?

@bitprophet
Member

I really should split that label up, in this case it just meant "there's no changelog entry yet". Changelog is in sites/www/changelog.rst if you want to take a stab, otherwise I will add an entry when I merge. Gonna throw this into next feature release since this is pretty small. Thanks!

@bitprophet bitprophet added this to the 1.11 milestone Jan 28, 2015
@bitprophet bitprophet changed the title from Added use_sudo as a kwarg to the sudo function. to Added use_sudo as a kwarg to the reboot function. Jan 28, 2015
@bitprophet bitprophet merged commit 648457d into fabric:master Apr 8, 2016

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details
@bitprophet bitprophet added a commit that referenced this pull request Apr 8, 2016
@bitprophet bitprophet Minor cleanup of patch re #1161 36b86ff
@bitprophet bitprophet added a commit that referenced this pull request Apr 8, 2016
@bitprophet bitprophet Changelog re #1161 8290367
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment