Include error message in task abort exception #1213

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@ipanousis

According to https://docs.python.org/2/library/sys.html the sys.exit([arg]) call will still result in error code of 1 for any non-zero object given. But at least by providing the error message it can be caught and inspected by the running program first.

Yannis Panousis Include error message in task abort exception
Change-Id: I22856d54b3d55663d8f11c8ad7efa9871a744c14
bdec53d
@bitprophet
Member

Seems like a useful enough change and I can't see any backwards compat issues with it, since as you mentioned this only adds info & does not change exit code. Thanks!

@bitprophet bitprophet added Support and removed Bug labels Nov 6, 2014
@bitprophet bitprophet added this to the 1.8.6/1.9.2 milestone Nov 6, 2014
@ipanousis

Hi, Thanks for your reply. I can see all these labels you have added but, as I'm not aware, does it mean you need me to follow up with something?

Thanks and pardon my ignorance,
Yannis

@bitprophet
Member

@ipanousis Nope just notes to myself for when I merge & release, thanks :)

@bitprophet bitprophet added a commit that closed this pull request Dec 19, 2014
@bitprophet bitprophet Changelog closes #1213 8fd468a
@bitprophet bitprophet added a commit that referenced this pull request May 4, 2015
@bitprophet bitprophet Add another test re: #1318, re #1213.
Also tweak previous test. Not sure why newline was different this time.
2d7a1b6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment