New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include error message in task abort exception #1213

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@ipanousis

ipanousis commented Oct 22, 2014

According to https://docs.python.org/2/library/sys.html the sys.exit([arg]) call will still result in error code of 1 for any non-zero object given. But at least by providing the error message it can be caught and inspected by the running program first.

Yannis Panousis
Include error message in task abort exception
Change-Id: I22856d54b3d55663d8f11c8ad7efa9871a744c14
@bitprophet

This comment has been minimized.

Member

bitprophet commented Nov 6, 2014

Seems like a useful enough change and I can't see any backwards compat issues with it, since as you mentioned this only adds info & does not change exit code. Thanks!

@bitprophet bitprophet added Support and removed Bug labels Nov 6, 2014

@bitprophet bitprophet added this to the 1.8.6/1.9.2 milestone Nov 6, 2014

@ipanousis

This comment has been minimized.

ipanousis commented Nov 6, 2014

Hi, Thanks for your reply. I can see all these labels you have added but, as I'm not aware, does it mean you need me to follow up with something?

Thanks and pardon my ignorance,
Yannis

@bitprophet

This comment has been minimized.

Member

bitprophet commented Nov 12, 2014

@ipanousis Nope just notes to myself for when I merge & release, thanks :)

bitprophet added a commit that referenced this pull request May 4, 2015

Add another test re: #1318, re #1213.
Also tweak previous test. Not sure why newline was different this time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment