Cross-platform `default_ssh_config_path` #1273

Closed
wants to merge 2 commits into
from

Projects

None yet

2 participants

@SamuelMarks
Contributor

No description provided.

@SamuelMarks
Contributor

@bitprophet Obviously that Travis CI build failing is some error on their end, as I've only changed two lines, one in code (which already passed Travis).

@bitprophet
Member

@SamuelMarks Yea that looks like a network error cascading into an actual error handling bug. Hilarious!

This looks good, and thanks. I'll merge & backport to 1.9/1.10 in a bit.

@bitprophet bitprophet added a commit that referenced this pull request Mar 5, 2015
@bitprophet Samuel Marks + bitprophet Added changelog for #1273
Conflicts:
	sites/www/changelog.rst
ad2f60b
@bitprophet
Member

FTR that error (which should've been tanking all recent fab builds) was due to a change in paramiko master, #22, which I did just go fix such that the test suite passes for me.

Restarted the Travis job and at least one of the cells passes now, so yay for that.

Backported as discussed, hopefully this will autoclose. EDIT: right, nope, because cherry picking. Plz 2 apply black magic there github? :D

@bitprophet bitprophet closed this Mar 5, 2015
@SamuelMarks
Contributor

Perfect, yeah was quite funny to see Travis failing tests on doc changes :P

@bitprophet
Member

Sadly I don't think it's feasible to make Travis smart enough to only run the bits of the test harness that are affected by a change (plus, due to using API docs, many code changes rightly affect doc builds anyways). We can dream :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment