New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-platform `default_ssh_config_path` #1273

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@SamuelMarks

SamuelMarks commented Feb 11, 2015

No description provided.

Samuel Marks
@SamuelMarks

This comment has been minimized.

SamuelMarks commented Mar 3, 2015

@bitprophet Obviously that Travis CI build failing is some error on their end, as I've only changed two lines, one in code (which already passed Travis).

@bitprophet

This comment has been minimized.

Member

bitprophet commented Mar 4, 2015

@SamuelMarks Yea that looks like a network error cascading into an actual error handling bug. Hilarious!

This looks good, and thanks. I'll merge & backport to 1.9/1.10 in a bit.

bitprophet added a commit that referenced this pull request Mar 5, 2015

Added changelog for #1273
Conflicts:
	sites/www/changelog.rst
@bitprophet

This comment has been minimized.

Member

bitprophet commented Mar 5, 2015

FTR that error (which should've been tanking all recent fab builds) was due to a change in paramiko master, #22, which I did just go fix such that the test suite passes for me.

Restarted the Travis job and at least one of the cells passes now, so yay for that.

Backported as discussed, hopefully this will autoclose. EDIT: right, nope, because cherry picking. Plz 2 apply black magic there github? :D

@bitprophet bitprophet closed this Mar 5, 2015

@SamuelMarks

This comment has been minimized.

SamuelMarks commented Mar 8, 2015

Perfect, yeah was quite funny to see Travis failing tests on doc changes :P

@bitprophet

This comment has been minimized.

Member

bitprophet commented Mar 9, 2015

Sadly I don't think it's feasible to make Travis smart enough to only run the bits of the test harness that are affected by a change (plus, due to using API docs, many code changes rightly affect doc builds anyways). We can dream :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment