WrappedCallableTask.__details__() support for multi-decorated objects #1286

Closed
wants to merge 3 commits into
from

Projects

None yet

2 participants

@mvk
Contributor
mvk commented Mar 4, 2015
  • fixes fabric/fabric #971
  • fixes fabric/fabric #1032
Max Kovgan WrappedCallableTask.__details__() support for multi-decorated objects
 - fixes fabric/fabric #971
 - fixes fabric/fabric #1032
68601ae
@mvk
Contributor
mvk commented Mar 4, 2015

The failure happens after the tests I've added passed. this is false positive on tests failure :(

@bitprophet
Member

Travis seems to have broken things across the board for our test suite, so no that's not your fault (and I am taking a look at it soon). Thanks for the submission :) Also, what's up with #1287, is that supposed to supersede this one or was it a mistaken push?

@mvk
Contributor
mvk commented Mar 5, 2015

Hi.
Not entirely, but the last commit out of these 3 is probably a Travis
phantom fix :)
On Mar 5, 2015 2:00 AM, "Jeff Forcier" notifications@github.com wrote:

Travis seems to have broken things across the board for our test suite, so
no that's not your fault. Thanks for the submission :) Also, what's up with
#1287 #1287, is that supposed to
supersede this one or was it a mistaken push?


Reply to this email directly or view it on GitHub
#1286 (comment).

@bitprophet
Member

Confirmed a downstream dev dependency broke our tests, thankfully I also run taht project now so I fixed it :3 kickstarted travis again to see what happens.

@mvk
Contributor
mvk commented Mar 5, 2015

Glad to hear. Do you want me to do anything or you're OK with cherry
picking?
On Mar 5, 2015 8:29 PM, "Jeff Forcier" notifications@github.com wrote:

Confirmed a downstream dev dependency broke our tests, thankfully I also
run taht project now so I fixed it :3 kickstarted travis again to see what
happens.


Reply to this email directly or view it on GitHub
#1286 (comment).

@bitprophet bitprophet closed this in 3510fed Mar 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment