Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1270 - Prevent installation on python3 #1416

Closed
wants to merge 1 commit into from

Conversation

@Daenyth
Copy link

@Daenyth Daenyth commented Jan 7, 2016

Given that python3 support isn't in this branch, it makes no sense to allow pip to install fabric.

This should make it bail out early.

Given that python3 support isn't in this branch, it makes no sense to allow pip to install fabric.

This should make it bail out early.
@bitprophet
Copy link
Member

@bitprophet bitprophet commented Jan 8, 2016

Neat, didn't realize they'd added that classifier. thanks!

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Jan 8, 2016

Hm, this doesn't work for me (made a python 3 virtualenv and pip installed and it still did so), and http://stackoverflow.com/questions/26278348/how-do-i-mark-a-python-package-as-python-2-only confirms that it's probably just a suggestion and not honored by pip :(

That said I may just go the crummy "check sys.version_info" approach while we're poking at this...

EDIT: feels crummy to put in a "please go follow development somewhere" note that then needs updating once 2.0 is public/live. Think I'll just put this in once that is taken care of, which as noted elsewhere, is hopefully soon.

@bitprophet bitprophet added this to the 2.0 milestone Jan 8, 2016
@pannous

This comment has been minimized.

Copy link

@pannous pannous commented on 0c56ef6 Jan 29, 2016

thanks, it will save many headaches!

This comment has been minimized.

Copy link
Owner Author

@Daenyth Daenyth replied Jan 29, 2016

@pannous See the PR notes; apparently pip doesn't honor this and reject it in the way I thought.

fabric#1416 (comment)

@Daenyth
Copy link
Author

@Daenyth Daenyth commented Apr 3, 2017

Even though this doesn't prevent installation it's still useful for tools like caniusepython3 and people reading the classifiers.

Merge if you want it or close if you don't?

@bitprophet bitprophet modified the milestones: 1.10.6, 2.0 Apr 22, 2017
@bitprophet
Copy link
Member

@bitprophet bitprophet commented Apr 22, 2017

Seems worth adding this to the 1.x branch for whichever 1.x releases keep happening, tossing it in next bugfix milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants