Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-platform support #1495

Closed
wants to merge 10 commits into from
Closed

Cross-platform support #1495

wants to merge 10 commits into from

Conversation

@ghost
Copy link

@ghost ghost commented Jul 31, 2016

Windows can now run OpenSSH server, however, test is not provided in portable GNU executables.
As per issue #1496, stat would provide a better replacement, especially since it exits in *NIX and Windows GNU portable executables!

Hamdi Sahloul added 4 commits Jul 31, 2016
Windows can now run OpenSSH server, however, test is not provided in portable GNU executables.
"stat" would provide a better replacement, especially since it exits in *NIX and Windows GNU portable executables!
Windows does not need path expansion!
Handle exception thrown when running 'ver' in Linux
@bitprophet
Copy link
Member

@bitprophet bitprophet commented Aug 1, 2016

@Sahloul notes in #1496 that ver is used here as a sentinel to determine remote platform. I don't know if it's the best way to do this offhand - is it available in all commonly found Windows versions out there? Are there any packages in popular Linux distros that might install a ver binary? etc.

Another random idea is to use the SFTP functionality to test file existence; though this has its own drawbacks (not all SSHDs have SFTP subsystem enabled; not usually possible to leverage sudo superpowers with SFTP; etc.)

Loading

Hamdi Sahloul added 2 commits Aug 2, 2016
Fixed expanding paths when remote server is Windows OS
@ghost
Copy link
Author

@ghost ghost commented Aug 2, 2016

@bitprophet You are right! Depending on ver was not a good idea after all..
I have proposed a clean workaround for both remote file existence and path expansion compatibility.

Loading

Hamdi Sahloul added 3 commits Aug 3, 2016
And refactored the code nicely.
docs warnings!
Inline emphasis fix
@ghost
Copy link
Author

@ghost ghost commented Aug 5, 2016

@bitprophet Mind to check what are the reasons for the build failure? I cannot understand its messages...

Loading

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Aug 8, 2016

@Sahloul the error is here: https://travis-ci.org/fabric/fabric/jobs/150021540#L1221 - looks like your docstring just isn't formatted as well as Sphinx wants, you need a code block or inline monospace or something. I can handle it whenever I merge, don't worry about it :) thanks!

Loading

@bitprophet bitprophet added this to the 1.10.5 milestone Aug 8, 2016
@ghost
Copy link
Author

@ghost ghost commented Aug 8, 2016

It was just the asterisk in *NIX ;)

Loading

@bitprophet bitprophet added this to the 1.13 milestone Aug 22, 2016
@bitprophet bitprophet removed this from the 1.10.5 milestone Aug 22, 2016
bitprophet added a commit that referenced this issue Aug 22, 2016
@bitprophet
Copy link
Member

@bitprophet bitprophet commented Aug 22, 2016

Originally cherry-picked this to 1.10 but then changed my mind; Github still isn't noticing though. Meh. It's in, will be released as part of 1.13. thanks!

Loading

@bitprophet bitprophet closed this Aug 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant