Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
fixes #1341: clean up temp file with sudo uploads if destination path… #1586
(for easier forward referencing: #1341)
Not sure how this got past me originally...looks all right at a glance, thanks!
Only downside is in the success case it's one extra shell command that is not strictly necessary, but I don't know if that bothers me a ton. Readability vs efficiency, I guess.
I think I'm okay with it as-is for now; as much as I enjoy beating people over the head with the readability clause, an extra almost-never-useful shell session inside something this frequently used & which would execute unconditionally, just leaves a bad taste.