keepalive maps to ServerAliveInterval #1631
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the documentation states that keepalive maps to ClientAliveInterval, which is a server side setting, unlike what the name indicates. The client side setting is called ServerAliveInterval. You can see references to this in the below two discussions: paramiko/paramiko#918 https://unix.stackexchange.com/a/3027/6475
|
Hrm this should've been fixed by #1065. Guessing git & moved paths strikes again? Thanks for noticing. |
|
Ah, apparently it was just a merge problem, it's there in 1.10 and 1.11 but not 1.12 upwards. Fixed that. Thanks again! EDIT: and the changelog entry was backwards; fixed that too. Thanks a lot, whoever named these settings in OpenSSH! |
|
I see, you fixed it back in 2015 but it didn't get to master. Thanks for taking care of it! |
|
Technically I think the commit was 2015, but I only actually cherry-picked or merged it this past April. (Yea... 😭 ) Anyway, all good now regardless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the documentation states that keepalive maps to ClientAliveInterval, which is a server side setting, unlike what the name indicates. The client side setting is called ServerAliveInterval. You can see references to this in the below two discussions:
paramiko/paramiko#918
https://unix.stackexchange.com/a/3027/6475