New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add close method to group objects #1709

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@kyrias

kyrias commented Jan 31, 2018

No description provided.

Add close method to group objects
Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
@kyrias

This comment has been minimized.

Show comment
Hide comment
@kyrias

kyrias Jan 31, 2018

Hm, pypy job failed while due to a network error when installing the dependencies.

kyrias commented Jan 31, 2018

Hm, pypy job failed while due to a network error when installing the dependencies.

@kyrias

This comment has been minimized.

Show comment
Hide comment
@kyrias

kyrias commented Feb 9, 2018

Ping?

@kyrias kyrias changed the title from Add close method to group objects to [v2] Add close method to group objects Mar 28, 2018

@bitprophet bitprophet closed this May 10, 2018

@kyrias kyrias changed the base branch from v2 to master Aug 25, 2018

@kyrias kyrias changed the title from [v2] Add close method to group objects to Add close method to group objects Aug 25, 2018

@kyrias

This comment has been minimized.

Show comment
Hide comment
@kyrias

kyrias Aug 25, 2018

@bitprophet Could this be reopened?

kyrias commented Aug 25, 2018

@bitprophet Could this be reopened?

@bitprophet

This comment has been minimized.

Show comment
Hide comment
@bitprophet

bitprophet Aug 27, 2018

Member

Not sure why this got closed, honestly, so sure!

Member

bitprophet commented Aug 27, 2018

Not sure why this got closed, honestly, so sure!

@bitprophet

This comment has been minimized.

Show comment
Hide comment
@bitprophet

bitprophet Aug 27, 2018

Member

Oh, I see. It's something specific on Github's end, possibly due to branch moving/renaming (which is probably also why I do not remember explicitly closing it). I literally can't reopen it. But I can cherry-pick the commit!

Member

bitprophet commented Aug 27, 2018

Oh, I see. It's something specific on Github's end, possibly due to branch moving/renaming (which is probably also why I do not remember explicitly closing it). I literally can't reopen it. But I can cherry-pick the commit!

bitprophet added a commit that referenced this pull request Aug 27, 2018

Don't actually think we need to make close() an abstract method yet.
Very remote chance we might want to later but I think even with
more 'exotic' implementations, the core 'treat it as an iterable'
aspect will remain intact, so we can rely on that.

Re #1709

bitprophet added a commit that referenced this pull request Aug 27, 2018

bitprophet added a commit that referenced this pull request Aug 27, 2018

bitprophet added a commit that referenced this pull request Aug 27, 2018

@bitprophet

This comment has been minimized.

Show comment
Hide comment
@bitprophet

bitprophet Aug 27, 2018

Member

All set!

Member

bitprophet commented Aug 27, 2018

All set!

@kyrias

This comment has been minimized.

Show comment
Hide comment
@kyrias

kyrias Aug 28, 2018

Awesome, thanks.

kyrias commented Aug 28, 2018

Awesome, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment