Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add close method to group objects #1709

Closed
wants to merge 1 commit into from
Closed

Add close method to group objects #1709

wants to merge 1 commit into from

Conversation

@kyrias
Copy link
Contributor

@kyrias kyrias commented Jan 31, 2018

No description provided.

Signed-off-by: Johannes Löthberg <johannes@kyriasis.com>
@kyrias
Copy link
Contributor Author

@kyrias kyrias commented Jan 31, 2018

Hm, pypy job failed while due to a network error when installing the dependencies.

@kyrias
Copy link
Contributor Author

@kyrias kyrias commented Feb 9, 2018

Ping?

@kyrias kyrias changed the title Add close method to group objects [v2] Add close method to group objects Mar 28, 2018
@bitprophet bitprophet closed this May 10, 2018
@kyrias kyrias changed the base branch from v2 to master Aug 25, 2018
@kyrias kyrias changed the title [v2] Add close method to group objects Add close method to group objects Aug 25, 2018
@kyrias
Copy link
Contributor Author

@kyrias kyrias commented Aug 25, 2018

@bitprophet Could this be reopened?

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Aug 27, 2018

Not sure why this got closed, honestly, so sure!

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Aug 27, 2018

Oh, I see. It's something specific on Github's end, possibly due to branch moving/renaming (which is probably also why I do not remember explicitly closing it). I literally can't reopen it. But I can cherry-pick the commit!

bitprophet added a commit that referenced this pull request Aug 27, 2018
Very remote chance we might want to later but I think even with
more 'exotic' implementations, the core 'treat it as an iterable'
aspect will remain intact, so we can rely on that.

Re #1709
bitprophet added a commit that referenced this pull request Aug 27, 2018
bitprophet added a commit that referenced this pull request Aug 27, 2018
bitprophet added a commit that referenced this pull request Aug 27, 2018
@bitprophet
Copy link
Member

@bitprophet bitprophet commented Aug 27, 2018

All set!

@kyrias
Copy link
Contributor Author

@kyrias kyrias commented Aug 28, 2018

Awesome, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants