New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPv6 host string support (#385) #491

Merged
merged 9 commits into from Sep 8, 2012

Conversation

Projects
None yet
3 participants
@max-arnold

max-arnold commented Dec 2, 2011

I updated host string normalization/denormalization functions to support ipv6 notation (plus related fix for contrib.sync_project). Parser is not very strict, but it works and passes all existing tests plus several new ones. The syntax examples are below:

::1
[::1]:1222
user@2001:db8::1
user@[2001:db8::1]:1222

Works for me on linux and os x, but more testing is certainly required.

max-arnold added some commits Nov 29, 2011

Allow IPv6 host addresses
Syntax examples:
  fe80::1111:2222:3333:4444
  user@fe80::1
  user@[::1]:2222 (square brackets are necessary for non-standard ssh port number)

@bitprophet bitprophet referenced this pull request Aug 3, 2012

Closed

IPv6 addresses #385

Merge branch 'master' into 385-ipv6-hosts
Conflicts:
	fabric/contrib/project.py
	fabric/network.py
@travisbot

This comment has been minimized.

travisbot commented Aug 25, 2012

This pull request passes (merged 6926996 into 994a76e).

@travisbot

This comment has been minimized.

travisbot commented Aug 25, 2012

This pull request passes (merged ab3778d into 994a76e).

@max-arnold

This comment has been minimized.

max-arnold commented Aug 25, 2012

I finally managed to update IPv6 branch to match the latest master, sorry for the delay.

@travisbot

This comment has been minimized.

travisbot commented Aug 26, 2012

This pull request fails (merged 62ac815 into 994a76e).

@bitprophet

This comment has been minimized.

Member

bitprophet commented Sep 8, 2012

Current Travis failure status looks like a temporary issue on their end or with Github. Will take a sec to try and update this locally & merge. Thanks a lot @max-arnold !

bitprophet added a commit that referenced this pull request Sep 8, 2012

@bitprophet bitprophet merged commit 62ac815 into fabric:master Sep 8, 2012

1 check failed

default The Travis build failed
Details
@max-arnold

This comment has been minimized.

max-arnold commented Sep 9, 2012

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment