Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include username in default password prompt #624

Merged

Conversation

@constfun
Copy link

@constfun constfun commented Apr 24, 2012

It is impossible to say what user the password is being asked for when the default password prompt is used. This is a tiny patch that will print the username when asking for a password.

@constfun
Copy link
Author

@constfun constfun commented Apr 24, 2012

Mucked up the commit range on this. I had 'master' as the range, which included my newer changes. Sorry.

Loading

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Apr 24, 2012

Weird, I don't think Github sent me a notification for your commit update, only your comment today :( sorry!

Loading

bitprophet added a commit that referenced this issue Apr 24, 2012
…1394d551

Include username in default password prompt
@bitprophet bitprophet merged commit 08c5a6a into fabric:master Apr 24, 2012
@bitprophet
Copy link
Member

@bitprophet bitprophet commented Apr 24, 2012

This broke the tests and needs a changelog entry, I'm fixing and backporting to 1.3/1.4.

Loading

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Apr 24, 2012

OK, that's all set. Thanks again!

Minor note for posterity: this isn't a 100% fix because it may not handle cases where the username is in the host string. There's no great way to fix that at the moment due to how prompt_for_password is implemented. This version of things is still much more informative than it was before, so it's a net plus in my book.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants