Include username in default password prompt #624

Merged
merged 2 commits into from Apr 24, 2012

Projects

None yet

2 participants

@pacemkr
Contributor
pacemkr commented Apr 24, 2012

It is impossible to say what user the password is being asked for when the default password prompt is used. This is a tiny patch that will print the username when asking for a password.

@bitprophet

If the language is tweaked a bit to read e.g. Login password for '%s', I can totally merge this :) thanks!

@pacemkr
Contributor
pacemkr commented Apr 24, 2012

Mucked up the commit range on this. I had 'master' as the range, which included my newer changes. Sorry.

@bitprophet
Member

Weird, I don't think Github sent me a notification for your commit update, only your comment today :( sorry!

@bitprophet bitprophet merged commit 08c5a6a into fabric:master Apr 24, 2012
@bitprophet
Member

This broke the tests and needs a changelog entry, I'm fixing and backporting to 1.3/1.4.

@bitprophet
Member

OK, that's all set. Thanks again!

Minor note for posterity: this isn't a 100% fix because it may not handle cases where the username is in the host string. There's no great way to fix that at the moment due to how prompt_for_password is implemented. This version of things is still much more informative than it was before, so it's a net plus in my book.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment