Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read system known_hosts file. #730

Closed
wants to merge 3 commits into from
Closed

Conversation

@roysmith
Copy link

@roysmith roysmith commented Sep 17, 2012

This patch provides a way to have fab read the system known_hosts file. This fixes the bug I reported to the mailing list in http://lists.gnu.org/archive/html/fab-user/2012-08/msg00017.html.

@@ -284,6 +284,14 @@ def connect(user, host, port):
# Init client
client = ssh.SSHClient()

# Load system hosts file (e.g. /etc/ssh/ssh_known_hosts)
try:
Copy link
Member

@bitprophet bitprophet Sep 17, 2012

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This try/except can be condensed into simply:

known_hosts = env.get('system_known_hosts')

as env is a dict subclass :)

Loading

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Sep 17, 2012

Please see comment; also please update the changelog too! Thanks :)

Loading

@roysmith
Copy link
Author

@roysmith roysmith commented Nov 19, 2012

Just wondering what the status of this pull request is. I see that version 1.5.1 was released recently, but doesn't appear to include this patch. Are there plans to pick up this patch at some point?

Loading

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Jan 23, 2013

Pro tip, if the ticket isn't "Closed", it's not been merged yet :) but that also usually means the plan is to do so and I just didn't get to it yet! Sorry for the delays.

Just did some touch-up on the changelog (new stuff goes at top, not bottom :)) and merging/testing now. Thanks!!

Loading

bitprophet added a commit that referenced this issue Jan 23, 2013
@bitprophet
Copy link
Member

@bitprophet bitprophet commented Jan 23, 2013

All set, will appear in 1.6.0 (next feature release). Which will be by end of month hopefully.

Loading

@bitprophet bitprophet closed this Jan 23, 2013
@roysmith
Copy link
Author

@roysmith roysmith commented Jan 23, 2013

Cool, thanks. And my apologies for getting the changelog backwards.

On Jan 22, 2013, at 11:44 PM, Jeff Forcier wrote:

All set, will appear in 1.6.0 (next feature release). Which will be by end of month hopefully.


Reply to this email directly or view it on GitHub.

Roy Smith
roy@panix.com

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants