Allow additional "success" return codes #735

Merged
merged 6 commits into from Dec 16, 2012

Conversation

Projects
None yet
2 participants
Contributor

opie4624 commented Sep 25, 2012

Added env.success_return_codes to allow specification of additional return codes that indicate success. This is useful to accomodate silly command line utilities (I'm looking at you @puppet) that return things other than 0 to indicate success.

Owner

bitprophet commented Oct 24, 2012

Strong +1 on the feature (in fact I'm surprised I can't find an earlier duplicate!)

Not a huge fan of how long the setting name itself is (though it's obviously readable/straightforward.) What else could we use here...success_codes? ok_exit? Ideal is something obvious but not too long to type when banging out code.

Contributor

opie4624 commented Oct 24, 2012

How about ok_ret_codes? Not overly long, but still fairly obvious. I'll see if I can update my pull request with that.

Owner

bitprophet commented Oct 24, 2012

That seems like a good compromise.

More nitpicks: 1.4 is already out, so your :versionadded needs to say 1.5 :) And if you could add an entry to the top of the changelog (following the format of previous entries, incl crediting yourself if you wish) that'll tie this up neatly and I can just merge and move on :D

Thanks a bunch!

Contributor

opie4624 commented Oct 24, 2012

Done, not nitpicky. 😄 Also caught my old master up so you should have minimal merge conflicts.

@bitprophet bitprophet added a commit that referenced this pull request Dec 16, 2012

@bitprophet bitprophet Doc edits re #735 b2fe050

@bitprophet bitprophet added a commit that referenced this pull request Dec 16, 2012

@bitprophet bitprophet Positive test re #735 246b0cf

bitprophet merged commit b16c578 into fabric:master Dec 16, 2012

1 check passed

default The Travis build passed
Details
Owner

bitprophet commented Dec 16, 2012

Sorry for the long delay -- all set now for 1.6, whenever that comes out (given holidays are upon us, probably January.) Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment