use_sudo with upload_project #826

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@abec
abec commented Jan 24, 2013

Added use_sudo with upload_project task. Thought it would be useful to others as well since I needed it.

@bitprophet
Member

Thanks, this looks good! Couple nitpicks and I can merge:

  • Merge with or rebase onto latest upstream master branch, a lot of stuff has gone in over the weekend.
  • Rename remote_exe to runner, this is a convention I've used in similar places, would prefer consistency :)
  • Add a changelog entry at the top of docs/changelog.rst following previous entries' style, including crediting yourself for the patch.
@bitprophet
Member

Oh, and also update the docstring for the function so it actually mentions the new setting + has .. versionadded: 1.6: the use_sudo parameter.

@bitprophet
Member

Just rebased on latest master (sincerest apologies 😢) and merged. Thanks!

@bitprophet bitprophet closed this May 27, 2013
@bitprophet bitprophet added a commit that referenced this pull request May 27, 2013
@bitprophet Abe + bitprophet Add use_sudo to upload_project task
Re #826
7e66a50
@bitprophet bitprophet added a commit that referenced this pull request May 27, 2013
@bitprophet bitprophet Update versionchanged re #826 f68c5b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment