Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use_sudo with upload_project #826

Closed
wants to merge 1 commit into from
Closed

Conversation

@generalpiston
Copy link

@generalpiston generalpiston commented Jan 24, 2013

Added use_sudo with upload_project task. Thought it would be useful to others as well since I needed it.

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Jan 28, 2013

Thanks, this looks good! Couple nitpicks and I can merge:

  • Merge with or rebase onto latest upstream master branch, a lot of stuff has gone in over the weekend.
  • Rename remote_exe to runner, this is a convention I've used in similar places, would prefer consistency :)
  • Add a changelog entry at the top of docs/changelog.rst following previous entries' style, including crediting yourself for the patch.
@bitprophet
Copy link
Member

@bitprophet bitprophet commented Jan 28, 2013

Oh, and also update the docstring for the function so it actually mentions the new setting + has .. versionadded: 1.6: the use_sudo parameter.

Abe
@bitprophet
Copy link
Member

@bitprophet bitprophet commented May 27, 2013

Just rebased on latest master (sincerest apologies 😢) and merged. Thanks!

@bitprophet bitprophet closed this May 27, 2013
bitprophet added a commit that referenced this pull request May 27, 2013
bitprophet added a commit that referenced this pull request May 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.