Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solved issue in rsync_project and implemented downstream synchronization #839

Closed
wants to merge 0 commits into from
Closed

Conversation

@apbarrero
Copy link

@apbarrero apbarrero commented Feb 13, 2013

When parsing for rsync address, the variable being parsed was 'env.host' instead of local 'host' which holds the actual value to be used.

Downstream synchronization option implemented.

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Feb 27, 2013

Why did you mix up a bugfix and a feature in the same PR? 😢 (link)

I'll cherry pick the bugfix part for now; the feature itself looks OK but I need to test it & it needs a changelog entry too.

bitprophet added a commit that referenced this pull request Feb 27, 2013
@apbarrero
Copy link
Author

@apbarrero apbarrero commented Mar 1, 2013

Sorry for the mixing up. Disclaimer: first PR. Thanks for the reference link.

About the feature, I got it working in my environment but had problems to run tests locally, so I couldn't debug so far. Still working on it.

@apbarrero apbarrero closed this Mar 1, 2013
@bitprophet
Copy link
Member

@bitprophet bitprophet commented Mar 1, 2013

@apbarrero No worries, that's why I added the link ;)

Please do make a new PR once you have the inverse-rsync stuff documented/tested/whatever. (Testing this part of things isn't 100% required right now, since it requires external programs/systems, but recording results of manual tests in-ticket would be awesome.)

Thanks!

@apbarrero
Copy link
Author

@apbarrero apbarrero commented Mar 3, 2013

New PR done. I filed a new issue before, so to get a number to reference in the changelog. Then I noticed the PR created a new issue itself. I'm kind of confused on how to proceed in this case :/

Thank you for maintaining this great tool!

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Mar 14, 2013

Yea, "Issues" and "Pull Requests" are muddled together unfortunately, PRs are effectively just a special case of Issue, are given Issue numbers and so forth. I closed the "extra" ticket so only the real PR is left now. Will poke at it momentarily, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants