Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweaking template_dir before apply_lcwd is called on a None object. #912

Closed
wants to merge 1 commit into from

Conversation

@yellottyellott
Copy link

@yellottyellott yellottyellott commented Jun 7, 2013

Issue #902

When calling upload_template with use_jinja=True and leaving template_dir=None, apply_lcwd is called with None
https://github.com/fabric/fabric/blob/master/fabric/contrib/files.py#L101

which calls os.path.isabs(None)
https://github.com/fabric/fabric/blob/master/fabric/utils.py#L356

which raises:

Python 2.7.2 (default, Oct 11 2012, 20:14:37)
[GCC 4.2.1 Compatible Apple Clang 4.0 (tags/Apple/clang-418.0.60)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> from os.path import isabs
>>> isabs(None)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/posixpath.py", line 53, in isabs
    return s.startswith('/')
AttributeError: 'NoneType' object has no attribute 'startswith'
>>>
@homm
Copy link

@homm homm commented Jun 7, 2013

Good.

@bitprophet
Copy link
Member

@bitprophet bitprophet commented Jun 8, 2013

Hey, thanks! Couple of things:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.