Fix getpass ImportError bug #983
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IIRC the 'unused' win32 imports here were necessary to trigger something behind the scenes in win32api. Either way, not comfortable removing them in code this old/stable, so I'm implementing the shuffle of the ImportError by itself. |
bitprophet
added a commit
that referenced
this pull request
Nov 27, 2018
ploxiln
pushed a commit
to ploxiln/fab-classic
that referenced
this pull request
Nov 27, 2018
ojrac
pushed a commit
to demiurgestudios/fabric
that referenced
this pull request
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In fabric/state.py. Function
_get_system_usernameon ImportError exception handling is a bug, is never triggered. And win32security and win32profile imported but unused