Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getpass ImportError bug #983

Closed
wants to merge 1 commit into from
Closed

Conversation

@dongweiming
Copy link

@dongweiming dongweiming commented Sep 15, 2013

In fabric/state.py. Function _get_system_username on ImportError exception handling is a bug, is never triggered. And win32security and win32profile imported but unused

@bitprophet bitprophet force-pushed the fabric:master branch from 294c08b to 66868af May 10, 2018
@bitprophet
Copy link
Member

@bitprophet bitprophet commented Nov 27, 2018

IIRC the 'unused' win32 imports here were necessary to trigger something behind the scenes in win32api. Either way, not comfortable removing them in code this old/stable, so I'm implementing the shuffle of the ImportError by itself.

bitprophet added a commit that referenced this pull request Nov 27, 2018
@bitprophet bitprophet added this to the 1.14.x / next 1.x bugfix milestone Nov 27, 2018
@bitprophet bitprophet closed this Nov 27, 2018
ploxiln added a commit to ploxiln/fab-classic that referenced this pull request Nov 27, 2018
ojrac added a commit to demiurgestudios/fabric that referenced this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.