Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

fix pcp pmdaprometheus configuration line #1975

Merged
merged 1 commit into from Apr 4, 2018
Merged

Conversation

fche
Copy link
Contributor

@fche fche commented Apr 4, 2018

Adapt to https://sourceware.org/git/?p=pcpfans.git;a=commitdiff;h=1f0a1f90bc8e01b5b28810ecd6a8cf505969f243, which changed the way pmdaprometheus is to be connected to from pmcd.

@fche
Copy link
Contributor Author

fche commented Apr 4, 2018

This will need to be done to the other prometheus-exporting modules too.
We hope not to break it again. :-(
cc @goodwinos

@fabric8cd
Copy link

@fche snapshot fabric8-wit image is available for testing. docker pull docker.io/fabric8/fabric8-wit:SNAPSHOT-PR-1975-1

@codecov-io
Copy link

Codecov Report

Merging #1975 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1975   +/-   ##
=======================================
  Coverage   64.67%   64.67%           
=======================================
  Files         147      147           
  Lines       13813    13813           
=======================================
  Hits         8934     8934           
  Misses       4045     4045           
  Partials      834      834

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e114051...e8f8245. Read the comment docs.

@aslakknutsen aslakknutsen merged commit e5d6ca0 into master Apr 4, 2018
@fche fche deleted the fche-patch-1 branch July 3, 2019 19:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants