This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
typo #286
Merged
typo #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aslakknutsen please approve and merge it. |
Current coverage is 48.32% (diff: 100%)@@ master #286 diff @@
==========================================
Files 33 33
Lines 1223 1223
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 591 591
Misses 592 592
Partials 40 40
|
kwk
reviewed
Sep 28, 2016
| @@ -157,7 +157,7 @@ generate: prebuild-check $(DESIGNS) $(GOAGEN_BIN) $(GO_BINDATA_ASSETFS_BIN) $(GO | |||
| $(GOAGEN_BIN) bootstrap -d ${PACKAGE_NAME}/${DESIGN_DIR} | |||
| $(GOAGEN_BIN) js -d ${PACKAGE_NAME}/${DESIGN_DIR} -o assets/ --noexample | |||
| $(GOAGEN_BIN) gen -d ${PACKAGE_NAME}/${DESIGN_DIR} --pkg-path=github.com/goadesign/gorma | |||
| PATH="$$(PATH):$(EXTRA_PATH)" $(GO_BINDATA_ASSETFS_BIN) -debug assets/... | |||
| PATH="$(PATH):$(EXTRA_PATH)" $(GO_BINDATA_ASSETFS_BIN) -debug assets/... | |||
There was a problem hiding this comment.
Why do you want to remove this $$ and change it to $. It has a purpose.
There was a problem hiding this comment.
currently it breaks the make generate
with this error
cd vendor/github.com/goadesign/goa/goagen && go build -v
github.com/almighty/almighty-core/vendor/github.com/dimfeld/httppath
github.com/almighty/almighty-core/vendor/github.com/goadesign/goa/dslengine
github.com/almighty/almighty-core/vendor/github.com/manveru/faker
github.com/almighty/almighty-core/vendor/github.com/zach-klippenstein/goregen
github.com/almighty/almighty-core/vendor/github.com/satori/go.uuid
github.com/almighty/almighty-core/vendor/github.com/goadesign/goa/version
github.com/almighty/almighty-core/vendor/golang.org/x/tools/go/ast/astutil
github.com/almighty/almighty-core/vendor/github.com/goadesign/goa/goagen/utils
github.com/almighty/almighty-core/vendor/github.com/spf13/pflag
github.com/almighty/almighty-core/vendor/gopkg.in/yaml.v2
github.com/almighty/almighty-core/vendor/github.com/goadesign/goa/design
github.com/almighty/almighty-core/vendor/github.com/spf13/cobra
github.com/almighty/almighty-core/vendor/github.com/goadesign/goa/goagen/codegen
github.com/almighty/almighty-core/vendor/github.com/goadesign/goa/goagen/meta
github.com/almighty/almighty-core/vendor/github.com/goadesign/goa/goagen
cd vendor/github.com/elazarl/go-bindata-assetfs/go-bindata-assetfs && go build -v
github.com/almighty/almighty-core/vendor/github.com/elazarl/go-bindata-assetfs/go-bindata-assetfs
cd vendor/github.com/jteeuwen/go-bindata/go-bindata && go build -v
github.com/almighty/almighty-core/vendor/github.com/jteeuwen/go-bindata
github.com/almighty/almighty-core/vendor/github.com/jteeuwen/go-bindata/go-bindata
vendor/github.com/goadesign/goa/goagen/goagen bootstrap -d github.com/almighty/almighty-core/design
app
app/contexts.go
app/controllers.go
app/security.go
app/hrefs.go
app/media_types.go
app/user_types.go
app/test
app/test/login_testing.go
app/test/tracker_testing.go
app/test/trackerquery_testing.go
app/test/version_testing.go
app/test/workitem_testing.go
app/test/workitemtype_testing.go
tool/cli
tool/cli/commands.go
client
client/client.go
client/login.go
client/tracker.go
client/trackerquery.go
client/version.go
client/workitem.go
client/workitemtype.go
client/user_types.go
client/media_types.go
swagger
swagger/swagger.json
swagger/swagger.yaml
vendor/github.com/goadesign/goa/goagen/goagen js -d github.com/almighty/almighty-core/design -o assets/ --noexample
assets/js
assets/js/client.js
assets/js/axios.min.js
vendor/github.com/goadesign/goa/goagen/goagen gen -d github.com/almighty/almighty-core/design --pkg-path=github.com/goadesign/gorma
PATH="$(PATH):vendor/github.com/jteeuwen/go-bindata/go-bindata" vendor/github.com/elazarl/go-bindata-assetfs/go-bindata-assetfs/go-bindata-assetfs -debug assets/...
/bin/sh: PATH: command not found
There was a problem hiding this comment.
@kwk: may i know the purpose for $$ ?
kwk
approved these changes
Sep 28, 2016
|
I wonder why this typo in the first place never produced build fail in Jenkins! |
|
In fact, there was an error in the Jenkins build. But exit code was zero! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.