This repository has been archived by the owner on Mar 11, 2021. It is now read-only.
Upgrade to Go 1.7.3 #433
Merged
Upgrade to Go 1.7.3 #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #433 +/- ##
==========================================
- Coverage 69.89% 69.86% -0.03%
==========================================
Files 78 78
Lines 5381 5383 +2
==========================================
Hits 3761 3761
- Misses 1256 1258 +2
Partials 364 364
Continue to review full report at Codecov.
|
sbose78
approved these changes
Nov 4, 2016
|
[test] |
|
-1 for the go upgrade in master. |
baijum
reviewed
Nov 4, 2016
Dockerfile.builder
Outdated
| @@ -15,6 +16,14 @@ RUN yum install -y \ | |||
| which \ | |||
| && yum clean all | |||
|
|
|||
| RUN wget https://storage.googleapis.com/golang/go$GO_VERSION.linux-amd64.tar.gz \ | |||
| && tar -xvf go$GO_VERSION.linux-amd64.tar.gz \ | |||
| && mv go /usr/local \ | |||
There was a problem hiding this comment.
Add && rm -fr /usr/local/go \ before this as a safeguard?
There was a problem hiding this comment.
@baijum I'd say, that if /usr/local/go exists. We're doing something wrong. No need to force it here, I guess.
hectorj2f
approved these changes
Feb 17, 2017
|
can we make do with 1.7.4 for the time being ? |
|
@kbsingh yea |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #426
Fixes #126