Skip to content
This repository has been archived by the owner on Mar 11, 2021. It is now read-only.

Support for opencompose file #465

Closed
wants to merge 1 commit into from

Conversation

surajssd
Copy link
Contributor

@surajssd surajssd commented Nov 9, 2016

Added services.yml file which has almighty application defined in OpenCompose file format.

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@aslakknutsen
Copy link
Contributor

Is there a way to use OpenCompose format with Docker Host/Machine?

@surajssd
Copy link
Contributor Author

surajssd commented Nov 9, 2016

@aslakknutsen OpenCompose is generic spec, and for POC we have plugged its implementation into Kompose. Kompose now supports generation of Kubernetes/OpenShift artifacts only.

So the answer is that no as of now there is no implementation which will deploy OpenCompose to Docker Host/Machine. But the idea is to get there with the spec.

@maxandersen
Copy link
Member

How do I run/use this ?

Please add info in readme.adoc on how to use it. Otherwise hard to comment/try out. Thanks!


Running almighty-core with OpenCompose

* Download kompose release with OpenCompose support from link:https://github.com/redhat-developer/opencompose/releases/tag/v0.1.1[here]. Extract that downloaded kompose release and put in path(This is a temporary solution, future releases will have packages or some form of better delivery mechanism).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick : Missing space after "path".

NOTE: If above commands fail you have no access to cluster.


Get services file:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about s/Get services file/Deploy the application using OpenCompose services.file : "

@surajssd surajssd force-pushed the opencompose_file branch 4 times, most recently from 596501d to 27fd676 Compare November 21, 2016 06:42
Added services.yml file which has almighty application defined
in opencompose file format.
@surajssd surajssd changed the title [WIP] Support for opencompose file Support for opencompose file Nov 21, 2016
@surajssd
Copy link
Contributor Author

@pradeepto your nitpick is addressed.
@maxandersen added usage instructions. This can be tested on OpenShift online. Please let me know if anything else that needs improvement.

@aslakknutsen
Copy link
Contributor

@surajssd Is there a way to reference secrets in there?

@pradeepto
Copy link

@aslakknutsen OpenCompose can't do that yet. So we need think about this. Also we have a related issue filed for Kompose.

@surajssd
Copy link
Contributor Author

@surajssd
Copy link
Contributor Author

@aslakknutsen ping for review on this!

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

2 similar comments
@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@pradeepto
Copy link

@maxandersen @aslakknutsen @surajssd @nimishamukherjee Can one of you please close this PR because it is obsolete (and deprecated)? Thanks.

@hectorj2f
Copy link

@pradeepto I can do that 👍

@hectorj2f hectorj2f closed this Jun 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants