Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

220 useproductized jolokia fuse 7.x.redhat #221

Conversation

apupier
Copy link
Contributor

@apupier apupier commented Feb 5, 2019

should we change also at these places?

io.fabric8.s2i.version.jolokia="1.5.0" \

&& curl http://central.maven.org/maven2/org/jolokia/jolokia-jvm/1.5.0/jolokia-jvm-1.5.0-agent.jar \

Why is it retrieving with curl? should we do it also with curl but with the maven redhat repository and productized version?

Signed-off-by: Aurélien Pupier <apupier@redhat.com>
@apupier apupier changed the base branch from master to fuse-7.x.redhat February 5, 2019 09:53
@vorburger
Copy link
Collaborator

vorburger commented Feb 5, 2019

@apupier thanks for your interest and PR for this project. Full disclosure: I am maintaining the community version (master branch) of this project as a "hobby", and not in an official capacity. Before today I never looked at the fabric8io-images:fuse-7.x.redhat branch, and when I just did for the first time I noticed that (my) test.sh does not even pass on it... I thought to have understand from @rhuss some time last year that this is no longer used, but given your interest, it seems it is? I therefore have a suggestion / invitation for you - would you like to step up to become the maintainer of non-master productized branches? You would have my +1 vote to get commit privilege on those branches and do what you think needs to be done... I would ignore non-master PRs, and not mind at all if you "self-merged" on those branches. Are you interested in proceeding like that? PS: Just FYI note #218.

@apupier
Copy link
Contributor Author

apupier commented Feb 5, 2019

I thought to have understand from @rhuss some time last year that this is no longer used, but given your interest, it seems it is?

I was pointed to this repo when i asked what is used to create the Fuse images: https://access.redhat.com/containers/?tab=overview#/registry.access.redhat.com/fuse7/fuse-java-openshift

to have the merge with jboss-container-images/openjdk might be a very good idea. It might explain why VS Code OpenShift connector is working with https://access.redhat.com/containers/?tab=overview#/registry.access.redhat.com/redhat-openjdk-18/openjdk18-openshift and not with https://access.redhat.com/containers/?tab=overview#/registry.access.redhat.com/fuse7/fuse-java-openshift . it is why I landed here.

I therefore have a suggestion / invitation for you - would you like to step up to become the maintainer of non-master productized branches?

thanks for the proposition. For now, I don't feel that I know enough about these images to be responsible to merge modifications with my only point of view. Maybe after I sort out which images relies on which one and why and in which way they diverged.

@vorburger
Copy link
Collaborator

I therefore have a suggestion / invitation for you - would you like to step up to become the maintainer of non-master productized branches?

thanks for the proposition. For now, I don't feel that I know enough about these images to be responsible to merge modifications with my only point of view. Maybe after I sort out which images relies on which one and why and in which way they diverged.

OK. Hope you understand that I won't merge this PR. Perhaps other old committers on this project will. Up to you know if you want to keep this open or when you want to Abandon to Close it - or let me know if you are interested after all.

@rhuss
Copy link
Contributor

rhuss commented Feb 6, 2019

@vorburger I see your point, but please note that we had from the very beginning a variant based on RHEL as a base image, which is used productized variations. So this repos supports both, plain community images but also RHEL based images. So I'm totally for merging this PR for RHEL images only.

@vorburger
Copy link
Collaborator

@rhuss I will not be able to help maintain the fuse-7.x.redhat branch on this project (only master).

@apupier
Copy link
Contributor Author

apupier commented Mar 12, 2020

closign as either things has moved from another side or still not moved and so there will be low probability that it happens oen day.

@apupier apupier closed this Mar 12, 2020
@apupier apupier deleted the 220-UseproductizedJolokia-fuse-7.x.redhat branch March 12, 2020 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants