Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Docker 1.12 HEALTHCHECK instruction #594

Closed
nicolaferraro opened this issue Oct 19, 2016 · 5 comments
Closed

Adding support for Docker 1.12 HEALTHCHECK instruction #594

nicolaferraro opened this issue Oct 19, 2016 · 5 comments
Labels

Comments

@nicolaferraro
Copy link
Member

I can work on this

@rhuss
Copy link
Collaborator

rhuss commented Oct 19, 2016

awesome, go ahead ...

@nicolaferraro
Copy link
Member Author

@rhuss do you think we should add something like this:

<image>
  <alias>box1</alias>
  <name>busybox</name>
  <build>
    <healthCheck>--interval=5s --timeout=3s CMD echo "good"</healthCheck>
  </build>
</image>

Or it's better the <healthCheck> to be a complex type, like:

<image>
  <alias>box1</alias>
  <name>busybox</name>
  <build>
    <healthCheck>
      <interval>5s</interval>
      <timeout>3s</timeout>
      <command>echo "good"</command>
    </healthCheck>
  </build>
</image>

I think I know the answer...

@rhuss
Copy link
Collaborator

rhuss commented Oct 19, 2016

LOL ;-P Didn't know that I'm so predictable :)

Of course I'd prefer the second solution, also because we could reuse Arguments for the actual healthcheck (wonder though, whether Docker supports this). Its also documented in https://dmp.fabric8.io/#misc-startup which could be reused, too.

There is another thing, which should be implemented, too. In initAndValidate the minimal Docker API version is calculated based on the features used. So, when a health check is used, then this minimal API version should be set to 1.24 (which is the API version of Docker 1.12)

nicolaferraro added a commit to nicolaferraro/docker-maven-plugin that referenced this issue Oct 21, 2016
@rhuss rhuss added the fixed label Oct 23, 2016
@rhuss
Copy link
Collaborator

rhuss commented Oct 24, 2016

0.16.9 with healthceck support is out.

@rhuss rhuss closed this as completed Oct 24, 2016
@danielwegener
Copy link
Contributor

Hi guys. Just curious, is this healthcheck also used during docker:start to ensure a proper start order? I am thinking about migrating wait statements to HEALTHCHECKs but need too keep the dependencies are started completely semantic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants