@@ Coverage Diff @@ ## master #969 +/- ## =========================================== - Coverage 51.57% 51.4% -0.18% Complexity 1232 1232 =========================================== Files 144 144 Lines 7251 7276 +25 Branches 981 985 +4 =========================================== Hits 3740 3740 - Misses 3195 3220 +25 Partials 316 316
rhuss left a comment
hey, looks good. Thanks !
Some minor change requests (see inline), otherwise looks good.
However, you should consider to add a documentation to the asciidoc, too and update the changelog.md
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.