fix (#1767): set default ping interval to 30 seconds

fabric8io · Sep 16, 2019 · 2b17994 · 2b17994
1 parent ed9a7ce
commit 2b17994
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/Config.java b/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/Config.java
@@ -126,7 +126,7 @@ public class Config {
   public static final Long DEFAULT_SCALE_TIMEOUT = 10 * 60 * 1000L;
   public static final int DEFAULT_LOGGING_INTERVAL = 20 * 1000;
   public static final Long DEFAULT_WEBSOCKET_TIMEOUT = 5 * 1000L;
-  public static final Long DEFAULT_WEBSOCKET_PING_INTERVAL = 1 * 1000L;
+  public static final Long DEFAULT_WEBSOCKET_PING_INTERVAL = 30 * 1000L;
 
   public static final Integer DEFAULT_MAX_CONCURRENT_REQUESTS = 64;
   public static final Integer DEFAULT_MAX_CONCURRENT_REQUESTS_PER_HOST = 5;

diff --git a/kubernetes-client/src/test/java/io/fabric8/kubernetes/client/ConfigTest.java b/kubernetes-client/src/test/java/io/fabric8/kubernetes/client/ConfigTest.java
@@ -460,6 +460,13 @@ public void shouldBeUsedTokenSuppliedByProvider() throws Exception {
     assertEquals("PROVIDER_TOKEN", config.getOauthToken());
   }
 
+  @Test
+  public void shouldHonorDefaultWebsocketPingInterval() {
+    Config config = new ConfigBuilder().build();
+
+    assertEquals(30000L, config.getWebsocketPingInterval());
+  }
+
   private void assertConfig(Config config) {
     assertNotNull(config);
     assertTrue(config.isTrustCerts());