New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support cascading delete on custom resources #1041

Open
rimesc opened this Issue Mar 21, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@rimesc

rimesc commented Mar 21, 2018

The interface returned by KubernetesClient.customResources(...) doesn't provide a method to set cascading=true.

The object itself (an instance of CustomResourcesOperationsImpl) does have a cascading flag, and a constructor that allows it to be specified, but it's defaulted to false in the only constructor that's actually used.

As a work around, you can construct an instance yourself using the constructor that does have the relevant parameter, but it would be helpful if the interface had a method for setting it, as other resource types do. It's worth noting that while technically the object does have a method for setting cascading=true that it inherits from the base class, casting to the base class and calling the method explodes because it uses reflection to find a suitable constructor and no such constructor exists in this case.

In particular, this makes it difficult to delete Argo workflows and their underlying pods.

@Nighthawk22

This comment has been minimized.

Nighthawk22 commented Apr 25, 2018

Any idea how to work around the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment