Changing the order of kubernetes workflow DSL command results in kubernetes-client validation exception

[rawlingsj]

Two examples which are the same apart from the second which fails has withEnvVar at the end.

working

node('kubernetes'){
    echo 'worked'
    kubernetes.pod('buildpod').withImage('fabric8/builder-openshift-client').withPrivileged(true).withHostPathMount('/var/run/docker.sock','/var/run/docker.sock').withEnvVar('DOCKER_CONFIG','/home/jenkins/.docker/').withSecret('jenkins-docker-cfg','/home/jenkins/.docker').withEnvVar('DOCKER_CONFIG','/home/jenkins/.docker/').inside {
      ...
    }
}

fails

node('kubernetes'){
    echo 'worked'
    kubernetes.pod('buildpod').withImage('fabric8/builder-openshift-client').withPrivileged(true).withHostPathMount('/var/run/docker.sock','/var/run/docker.sock').withEnvVar('DOCKER_CONFIG','/home/jenkins/.docker/').withEnvVar('DOCKER_CONFIG','/home/jenkins/.docker/').withSecret('jenkins-docker-cfg','/home/jenkins/.docker').inside {
      ...
    }
}

io.fabric8.kubernetes.client.KubernetesClientException: Failure executing: POST at: https://kubernetes.default.svc/api/v1/namespaces/default/pods. Message: Pod "buildpod-694cc974-885c-4b62-85e9-fc56b1ee587e" is invalid: [spec.containers[0].env[1].name: invalid value 'jenkins-docker-cfg', Details: must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.containers[0].env[3].name: invalid value 'jenkins-docker-cfg', Details: must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName"]. Received status: Status(apiVersion=v1, code=422, details=StatusDetails(causes=[StatusCause(field=spec.containers[0].env[1].name, message=invalid value 'jenkins-docker-cfg', Details: must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", reason=FieldValueInvalid, additionalProperties={}), StatusCause(field=spec.containers[0].env[3].name, message=invalid value 'jenkins-docker-cfg', Details: must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", reason=FieldValueInvalid, additionalProperties={})], kind=Pod, name=buildpod-694cc974-885c-4b62-85e9-fc56b1ee587e, retryAfterSeconds=null, additionalProperties={}), kind=Status, message=Pod "buildpod-694cc974-885c-4b62-85e9-fc56b1ee587e" is invalid: [spec.containers[0].env[1].name: invalid value 'jenkins-docker-cfg', Details: must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName", spec.containers[0].env[3].name: invalid value 'jenkins-docker-cfg', Details: must be a C identifier (matching regex [A-Za-z_][A-Za-z0-9_]*): e.g. "my_name" or "MyName"], metadata=ListMeta(resourceVersion=null, selfLink=null, additionalProperties={}), reason=Invalid, status=Failure, additionalProperties={}).
    at io.fabric8.kubernetes.client.dsl.base.OperationSupport.requestFailure(OperationSupport.java:263)
    at io.fabric8.kubernetes.client.dsl.base.OperationSupport.assertResponseCode(OperationSupport.java:234)
    at io.fabric8.kubernetes.client.dsl.base.OperationSupport.handleResponse(OperationSupport.java:207)
    at io.fabric8.kubernetes.client.dsl.base.OperationSupport.handleCreate(OperationSupport.java:185)
    at io.fabric8.kubernetes.client.dsl.base.BaseOperation.handleCreate(BaseOperation.java:475)
    at io.fabric8.kubernetes.client.dsl.base.BaseOperation.create(BaseOperation.java:206)
    at io.fabric8.kubernetes.client.dsl.base.BaseOperation$1.visit(BaseOperation.java:223)
    at io.fabric8.kubernetes.api.model.DoneablePod.done(DoneablePod.java:20)
    at io.fabric8.kubernetes.workflow.KubernetesFacade.createPod(KubernetesFacade.java:128)
    at io.fabric8.kubernetes.workflow.PodStepExecution.start(PodStepExecution.java:63)
    at org.jenkinsci.plugins.workflow.cps.DSL.invokeMethod(DSL.java:136)
    at org.jenkinsci.plugins.workflow.cps.CpsScript.invokeMethod(CpsScript.java:112)
    at org.codehaus.groovy.runtime.callsite.PogoMetaClassSite.call(PogoMetaClassSite.java:45)
    at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:42)
    at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:108)
    at com.cloudbees.groovy.cps.sandbox.DefaultInvoker.methodCall(DefaultInvoker.java:15)
    at io.fabric8.kubernetes.workflow.Kubernetes$Pod.inside(jar:file:/var/jenkins_home/plugins/kubernetes-workflow/WEB-INF/lib/kubernetes-workflow.jar!/io/fabric8/kubernetes/workflow/Kubernetes.groovy:100)
    at io.fabric8.kubernetes.workflow.Kubernetes.node(jar:file:/var/jenkins_home/plugins/kubernetes-workflow/WEB-INF/lib/kubernetes-workflow.jar!/io/fabric8/kubernetes/workflow/Kubernetes.groovy:30)
    at io.fabric8.kubernetes.workflow.Kubernetes$Pod.inside(jar:file:/var/jenkins_home/plugins/kubernetes-workflow/WEB-INF/lib/kubernetes-workflow.jar!/io/fabric8/kubernetes/workflow/Kubernetes.groovy:99)
    at WorkflowScript.run(WorkflowScript:3)
    at Unknown.Unknown(Unknown)
    at ___cps.transform___(Native Method)
    at com.cloudbees.groovy.cps.impl.ContinuationGroup.methodCall(ContinuationGroup.java:69)
    at com.cloudbees.groovy.cps.impl.FunctionCallBlock$ContinuationImpl.dispatchOrArg(FunctionCallBlock.java:106)
    at com.cloudbees.groovy.cps.impl.FunctionCallBlock$ContinuationImpl.fixArg(FunctionCallBlock.java:79)
    at sun.reflect.GeneratedMethodAccessor139.invoke(Unknown Source)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:497)
    at com.cloudbees.groovy.cps.impl.ContinuationPtr$ContinuationImpl.receive(ContinuationPtr.java:72)
    at com.cloudbees.groovy.cps.impl.ClosureBlock.eval(ClosureBlock.java:40)
    at com.cloudbees.groovy.cps.Next.step(Next.java:58)
    at com.cloudbees.groovy.cps.Continuable.run0(Continuable.java:145)
    at org.jenkinsci.plugins.workflow.cps.CpsThread.runNextChunk(CpsThread.java:164)
    at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.run(CpsThreadGroup.java:274)
    at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.access$000(CpsThreadGroup.java:74)
    at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:183)
    at org.jenkinsci.plugins.workflow.cps.CpsThreadGroup$2.call(CpsThreadGroup.java:181)
    at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$2.call(CpsVmExecutorService.java:47)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:112)
    at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
    at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
    at java.util.concurrent.FutureTask.run(FutureTask.java:266)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at java.lang.Thread.run(Thread.java:745)
Finished: FAILURE

[stale]

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!