chore: create Jandex index #1367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes lookup of classes faster in environments that use Jandex, providing better performance in some environments
|
@rohanKanojia tests passed but I don't know why the |
|
ok to test |
|
@gastaldi : we have to whitelist PRs first ;-) |
oscerd
approved these changes
Feb 22, 2019
rohanKanojia
requested changes
Feb 22, 2019
There was a problem hiding this comment.
looks good, Thanks 👍
I'm just not clear about the use case for adding this plugin. I looked into jandex-plugin-website here: http://docs.wildfly.org/jandex-maven-plugin/1.0.1/source-repository.html . How much build time is used additionally to build up the index? Can we put this plugin in release profile rather than main build?
Also, would be awesome if you could add a line about this change to CHANGELOG :-)
rohanKanojia
added
the
changelog missing
|
Ok to test |
rohanKanojia
removed
the
changelog missing
rohanKanojia
approved these changes
Feb 23, 2019
|
[merge] |
|
@gastaldi: I like the way you think! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes lookup of classes faster in environments that use Jandex, providing better performance in some environments