Fix for getting correct client X/Y coords when touch supported #315

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
@sjpemberton
Contributor

sjpemberton commented Nov 14, 2012

Quick fix to help touch supported devices when canvas is NOT in a scrolled container.

@kangax

This comment has been minimized.

Show comment
Hide comment
@kangax

kangax Nov 15, 2012

Member

Why don't we use fabric.isTouchSupported instead?

Member

kangax commented Nov 15, 2012

Why don't we use fabric.isTouchSupported instead?

@sjpemberton

This comment has been minimized.

Show comment
Hide comment
@sjpemberton

sjpemberton Nov 15, 2012

Contributor

Hey Kangax,

All I did was copy the old method contents from PointerX/Y when isTouchSupported is true.

As we always use the event.clientX/Y coords now, I didn't see the need to explicitly check for touch support before hand.
Of course there's no harm in it so can add it in if you like.

Either way we still need to find away of handling scrolling parents when isTouchSupported is true.
I have a feeling the scroll always takes priority.

Contributor

sjpemberton commented Nov 15, 2012

Hey Kangax,

All I did was copy the old method contents from PointerX/Y when isTouchSupported is true.

As we always use the event.clientX/Y coords now, I didn't see the need to explicitly check for touch support before hand.
Of course there's no harm in it so can add it in if you like.

Either way we still need to find away of handling scrolling parents when isTouchSupported is true.
I have a feeling the scroll always takes priority.

@sjpemberton

This comment has been minimized.

Show comment
Hide comment
@sjpemberton

sjpemberton Dec 13, 2012

Contributor

No need for this with the recent 9.30 build

Contributor

sjpemberton commented Dec 13, 2012

No need for this with the recent 9.30 build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment