From bbd04c4656b422efb621bc1ac5ac88d7db507e7c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabr=C3=ADzio=20de=20Royes=20Mello?= Date: Thu, 22 Sep 2022 18:29:36 -0300 Subject: [PATCH] Fix missing upgrade/downgrade tests DDL validation Recently we fixed a DDL error (#4739) after upgrading to 2.8.0 version that surprisly the CI upgrade/dowgrade tests didn't complained during the development of the feature (#4552). Fixed it by adding an specific query in the `post.catalog.sql` script to make sure we'll check all the constraints of our internal tables and catalog. --- test/sql/updates/post.catalog.sql | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/test/sql/updates/post.catalog.sql b/test/sql/updates/post.catalog.sql index f08e7a48ff1..4c022e6b483 100644 --- a/test/sql/updates/post.catalog.sql +++ b/test/sql/updates/post.catalog.sql @@ -27,9 +27,9 @@ WHERE classoid = 'pg_class'::regclass ORDER BY schema, name, initpriv; \di _timescaledb_catalog.* -\ds+ _timescaledb_catalog.*; -\df _timescaledb_internal.*; -\df+ _timescaledb_internal.*; +\ds+ _timescaledb_catalog.* +\df _timescaledb_internal.* +\df+ _timescaledb_internal.* \df public.*; \df+ public.*; @@ -43,9 +43,7 @@ SELECT count(*) AND refobjid = (SELECT oid FROM pg_extension WHERE extname = 'timescaledb'); -- The list of tables configured to be dumped. -SELECT obj::regclass::text -FROM (SELECT unnest(extconfig) AS obj FROM pg_extension WHERE extname='timescaledb') AS objects -ORDER BY obj::regclass::text; +SELECT unnest(extconfig)::regclass::text AS obj FROM pg_extension WHERE extname='timescaledb' ORDER BY 1; -- Show dropped chunks SELECT * @@ -75,3 +73,8 @@ FROM pg_depend dep WHERE classid='pg_class'::regclass ORDER BY attrelid::regclass::text,att.attnum; +-- Show constraints +SELECT conrelid::regclass::text, conname, pg_get_constraintdef(oid) +FROM pg_constraint +WHERE conrelid::regclass::text ~ '^_timescaledb_' +ORDER BY 1, 2, 3;