Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/journal #100

Merged
merged 18 commits into from Aug 22, 2019

Conversation

@dubhcait
Copy link
Collaborator

commented Aug 20, 2019

No description provided.

@dubhcait dubhcait requested a review from IsraaSulaiman Aug 21, 2019

setThoughts(data.data);
setLoading(false);
})
.catch(err => console.log(err));

This comment has been minimized.

Copy link
@IsraaSulaiman

IsraaSulaiman Aug 21, 2019

Contributor

instead of logging the error, you could display it in a span or using the notification

This comment has been minimized.

Copy link
@dubhcait

dubhcait Aug 22, 2019

Author Collaborator

ya on it

try {
let { id } = req.auth;
const result = await selectThoughts(id);
console.log(result);

This comment has been minimized.

Copy link
@IsraaSulaiman

IsraaSulaiman Aug 21, 2019

Contributor

remove the console.log 😁

This comment has been minimized.

Copy link
@dubhcait

dubhcait Aug 22, 2019

Author Collaborator

oups

@@ -5,13 +5,14 @@ module.exports = (userId, emoji, thought) => {
try {
const date = new Date();
const dateString = `${date.getDate()}/${date.getMonth()}`;
console.log("f");

This comment has been minimized.

Copy link
@IsraaSulaiman

IsraaSulaiman Aug 21, 2019

Contributor

console.log 😁

This comment has been minimized.

Copy link
@dubhcait

dubhcait Aug 22, 2019

Author Collaborator

👍

@dubhcait dubhcait merged commit 352d60a into staging Aug 22, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@IsraaSulaiman IsraaSulaiman deleted the feature/journal branch Aug 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.