Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rely on external resources #208

merged 5 commits into from Jan 2, 2020


Copy link

This PR should fix #134.

  • Remove link to Font Awesome CDN
  • Set icons as SVG Vue components
  • Use SVG symbols to reduce duplication in output (especially the 'pencil' icon)

Copy link

miclf commented Dec 23, 2019

Hello there! I’m wondering if there is any plan to merge this pull request anytime soon? :)

I recently discovered that one of the slightly annoying effects of the issue being solved here is that, when you develop while being offline (e.g. in NMBS/SNCB trains), the links to open code editors are not even displayed, since the icons are not downloaded and there isn’t any fallback text as link content.
The links are obviously present in the HTML page, but they have dimensions of zero.

Illustration with Firefox devtools:

Capture d’écran 2019-12-23 à 02 44 42

@freekmurze freekmurze merged commit 6328b1b into master Jan 2, 2020
@freekmurze freekmurze deleted the no-external-resources branch January 2, 2020 12:00
ngyikp added a commit to ricochetuniverse/ricochet-universe that referenced this pull request Mar 26, 2022
Ignition doesn't need external Font Awesome anymore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet
4 participants