Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement an extensible Logging System #69

Closed
ntotten opened this issue Feb 6, 2012 · 1 comment
Closed

Implement an extensible Logging System #69

ntotten opened this issue Feb 6, 2012 · 1 comment
Labels

Comments

@ntotten
Copy link
Contributor

ntotten commented Feb 6, 2012

Enable support for logging.

@prabirshrestha
Copy link
Member

do we need this now?

This can actually be moved to an entire new project Facebook.Logger.dll by changing the HttpWebRequestFactory. Similar like how I implemented Facebook.Moq (http://nuget.org/packages/Facebook.Moq) We can limit the focus scope of Facebook.dll and there hasn't been any requests from outside who wants this feature.

Func<Uri, HttpWebRequestWrapper> HttpWebRequestFactory

Default for all can be changed using the static method.

public static void SetDefaultHttpWebRequestFactory(Func<Uri, HttpWebRequestWrapper> httpWebRequestFactory);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants