This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Fix selection inconsistency in ASTableView/ASCollectionView cell implementation #837
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@levi this looks like an improvement. Question: how does one cause an un-selection from the ASCellNode? If I get setSelected: called on my ASCellNode instance, how would I trigger an un-selection? Don't we need some kind of back-pointer to the cell view object? |
Contributor
Author
|
Good question, @appleguy. Will take a look at this other case. |
appleguy
added a commit
that referenced
this pull request
Nov 29, 2015
Fix selection inconsistency in ASTableView/ASCollectionView cell implementation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like some of the state wasn't being correctly passed through to the ASCellNode on cell population.
Fixes #807