This repository was archived by the owner on Feb 2, 2023. It is now read-only.
Adds ASVisualEffectNode which is a wrapper around UIVisualEffectView #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsyncDisplayKit/ASVisualEffectNode.h
Outdated
Contributor
There was a problem hiding this comment.
You'll want to include this header in AsyncDisplayKit.h so that it can be used outside of the framework. Also, update the copyright preamble to reflect the one used in the other classes.
samhsiung
force-pushed
the
visual_effect
branch
from
4f9bbfb to
48e5830
Compare
Contributor
|
Cool idea! We may want to install some checks or robustness around this to make sure that people aren't confused if they try to do shouldRasterizeDescendents and find that the effect is missing. Might be able to throw an assertion if rasterization encounters one of these nodes... |
Contributor
Author
|
Going to test contentView children functionality some more |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Future plans could be to add child nodes to UIVisualEffectView's contentView and not it's subview which Apple recommends:
After you add the visual effect view to the view hierarchy, add any subviews to the contentView property of the visual effect view. Do not add subviews directly to the visual effect view itself.https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIVisualEffectView/