Allow batch trial to be constructed with a list of GRs #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51211147 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Nov 16, 2023
Summary: This makes creating trials from `GS.gen_for_multiple_trial_from_multiple()` models easier in D51307866 and is closer to the way `BatchTrial`s actually work. Reviewed By: lena-kashtelyan Differential Revision: D51211147
danielcohenlive
force-pushed
the
export-D51211147
branch
from
90287ad
to
c3b50b9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51211147 |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Nov 16, 2023
Summary: This makes creating trials from `GS.gen_for_multiple_trial_from_multiple()` models easier in D51307866 and is closer to the way `BatchTrial`s actually work. Reviewed By: lena-kashtelyan Differential Revision: D51211147
danielcohenlive
force-pushed
the
export-D51211147
branch
from
c3b50b9
to
1277da0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51211147 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1995 +/- ##
==========================================
+ Coverage 94.48% 94.53% +0.05%
==========================================
Files 460 460
Lines 44022 44086 +64
==========================================
+ Hits 41594 41677 +83
+ Misses 2428 2409 -19 ☔ View full report in Codecov by Sentry. |
danielcohenlive
pushed a commit
to danielcohenlive/Ax-1
that referenced
this pull request
Nov 21, 2023
Summary: This makes creating trials from `GS.gen_for_multiple_trial_from_multiple()` models easier in D51307866 and is closer to the way `BatchTrial`s actually work. Reviewed By: lena-kashtelyan Differential Revision: D51211147
danielcohenlive
force-pushed
the
export-D51211147
branch
from
1277da0
to
c70275e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51211147 |
Summary: This makes creating trials from `GS.gen_for_multiple_trial_from_multiple()` models easier in D51307866 and is closer to the way `BatchTrial`s actually work. Reviewed By: lena-kashtelyan Differential Revision: D51211147
danielcohenlive
force-pushed
the
export-D51211147
branch
from
c70275e
to
f2d525b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51211147 |
|
This pull request has been merged in 50790cc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This makes creating trials from
GS.gen_for_multiple_trial_from_multiple()models easier in D51307866 and is closer to the wayBatchTrials actually work.Reviewed By: lena-kashtelyan
Differential Revision: D51211147