Add Decorator for GenerationStep only functions in GenerationStrategy #2045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D51816513 |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2045 +/- ##
==========================================
+ Coverage 94.52% 94.61% +0.08%
==========================================
Files 460 460
Lines 44638 44845 +207
==========================================
+ Hits 42195 42429 +234
+ Misses 2443 2416 -27 ☔ View full report in Codecov by Sentry. |
mgarrard
force-pushed
the
export-D51816513
branch
from
621f017
to
27bde9b
Compare
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Dec 6, 2023
…facebook#2045) Summary: This diff does the following: Add decorator for functions that are only supported in steps -- this prevents some code redundancy upcoming: (1) update the storage to include nodes independently (and not just as part of step) (2) delete now unused GenStep functions (3) final pass on all the doc strings and variables -- lots to clean up here (4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode (5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed (6) rename transiton criterion to action criterion (7) remove conditionals for legacy usecase ( clean up any lingering todos Reviewed By: lena-kashtelyan Differential Revision: D51816513
|
This pull request was exported from Phabricator. Differential Revision: D51816513 |
mgarrard
force-pushed
the
export-D51816513
branch
from
27bde9b
to
bee22e0
Compare
mgarrard
pushed a commit
to mgarrard/Ax
that referenced
this pull request
Dec 6, 2023
…facebook#2045) Summary: This diff does the following: Add decorator for functions that are only supported in steps -- this prevents some code redundancy upcoming: (1) update the storage to include nodes independently (and not just as part of step) (2) delete now unused GenStep functions (3) final pass on all the doc strings and variables -- lots to clean up here (4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode (5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed (6) rename transiton criterion to action criterion (7) remove conditionals for legacy usecase ( clean up any lingering todos Reviewed By: lena-kashtelyan Differential Revision: D51816513
|
This pull request was exported from Phabricator. Differential Revision: D51816513 |
added 2 commits
December 6, 2023 17:04
… default to GenerationNodes (facebook#2024) Summary: This diff does the following: Supports GenerationNodes at the level of GenerationStrategy. This is the big hurrah diff! upcoming: (0) Add decorator for functions that are only supported in steps (1) update the storage to include nodes independently (and not just as part of step) (2) delete now unused GenStep functions (3) final pass on all the doc strings and variables -- lots to clean up here (4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode (5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed (6) rename transiton criterion to action criterion (7) remove conditionals for legacy usecase (8) clean up any lingering todos Reviewed By: lena-kashtelyan Differential Revision: D51120002
…facebook#2045) Summary: This diff does the following: Add decorator for functions that are only supported in steps -- this prevents some code redundancy upcoming: (1) update the storage to include nodes independently (and not just as part of step) (2) delete now unused GenStep functions (3) final pass on all the doc strings and variables -- lots to clean up here (4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode (5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed (6) rename transiton criterion to action criterion (7) remove conditionals for legacy usecase ( clean up any lingering todos Reviewed By: lena-kashtelyan Differential Revision: D51816513
mgarrard
force-pushed
the
export-D51816513
branch
from
bee22e0
to
d3906b0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D51816513 |
|
This pull request has been merged in a28e851. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff does the following:
Add decorator for functions that are only supported in steps -- this prevents some code redundancy
upcoming:
(1) update the storage to include nodes independently (and not just as part of step)
(2) delete now unused GenStep functions
(3) final pass on all the doc strings and variables -- lots to clean up here
(4) add transition criterion to the repr string + some of the other fields that havent made it yet on GeneratinoNode
(5) Do a final pass of the generationStrategy/GenerationNode files to see what else can be migrated/condensed
(6) rename transiton criterion to action criterion
(7) remove conditionals for legacy usecase
( clean up any lingering todos
Differential Revision: D51816513