Introduces AxGenerationException to facilitate exception handling #2254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Adds AxGenerationException so that we can catch exceptions from within the GenerationStrategy without needing to `except Exception`, which was obscuring error messages and making it harder to debug. Reviewed By: saitcakmak Differential Revision: D54604928
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D54604928 |
|
This pull request has been merged in e4d632a. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Adds AxGenerationException so that we can catch exceptions from within the GenerationStrategy without needing to
except Exception, which was obscuring error messages and making it harder to debug.Reviewed By: saitcakmak
Differential Revision: D54604928