Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Light GenStrategy cleanup #2258

Closed

Conversation

lena-kashtelyan
Copy link
Contributor

Summary: As titled, grab-bag of no-op cleanups + coverage improvement

Differential Revision: D54639831

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Mar 8, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54639831

lena-kashtelyan pushed a commit to lena-kashtelyan/Ax that referenced this pull request Mar 18, 2024
Summary:

As titled, grab-bag of no-op cleanups + coverage improvement

Differential Revision: D54639831
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54639831

lena-kashtelyan pushed a commit to lena-kashtelyan/Ax that referenced this pull request Mar 18, 2024
Summary:

As titled, grab-bag of no-op cleanups + coverage improvement

Differential Revision: D54639831
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54639831

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.91%. Comparing base (54996ed) to head (f345147).

❗ Current head f345147 differs from pull request most recent head 3683a81. Consider uploading reports for the commit 3683a81 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2258   +/-   ##
=======================================
  Coverage   94.90%   94.91%           
=======================================
  Files         489      489           
  Lines       47584    47575    -9     
=======================================
- Hits        45159    45154    -5     
+ Misses       2425     2421    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Summary:

As titled, grab-bag of no-op cleanups + coverage improvement

Reviewed By: lena-kashtelyan

Differential Revision: D54639831
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D54639831

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in f062de8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants