Address non-determinism in model.metric_names in tests #2309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D55639863 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2309 +/- ##
=======================================
Coverage 94.90% 94.91%
=======================================
Files 489 489
Lines 47751 47754 +3
=======================================
+ Hits 45317 45324 +7
+ Misses 2434 2430 -4 ☔ View full report in Codecov by Sentry. |
Summary: Tests in D50501707 assumed that model.metric_names would always be the same order, leading to non-deterministic failures (T184254958). This addresses. Reviewed By: Balandat Differential Revision: D55639863
bernardbeckerman
force-pushed
the
export-D55639863
branch
from
196ca8b
to
f55872d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D55639863 |
|
This pull request has been merged in e956132. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Tests in D50501707 assumed that model.metric_names would always be the same order, leading to non-deterministic failures (T184254958). This addresses.
Differential Revision: D55639863