From ba40813a79f2f6e557337bcf37decc0c8ca3d1b6 Mon Sep 17 00:00:00 2001 From: Shruti Patel Date: Wed, 1 Apr 2026 20:30:15 -0700 Subject: [PATCH] Fix typo: get_aditional_attrs -> get_additional_attrs Summary: Self-explanatory as per the title Differential Revision: D99218035 --- ax/analysis/healthcheck/healthcheck_analysis.py | 2 +- .../healthcheck/tests/test_can_generate_candidates.py | 8 ++++---- ax/analysis/healthcheck/tests/test_complexity_rating.py | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/ax/analysis/healthcheck/healthcheck_analysis.py b/ax/analysis/healthcheck/healthcheck_analysis.py index 8f220c38396..0cabccc98b3 100644 --- a/ax/analysis/healthcheck/healthcheck_analysis.py +++ b/ax/analysis/healthcheck/healthcheck_analysis.py @@ -39,7 +39,7 @@ def is_user_facing(self) -> bool: """ return self.get_status() != HealthcheckStatus.PASS - def get_aditional_attrs(self) -> dict[str, str | int | float | bool]: + def get_additional_attrs(self) -> dict[str, str | int | float | bool]: return json.loads(self.blob) diff --git a/ax/analysis/healthcheck/tests/test_can_generate_candidates.py b/ax/analysis/healthcheck/tests/test_can_generate_candidates.py index e166a97cc99..4837489de83 100644 --- a/ax/analysis/healthcheck/tests/test_can_generate_candidates.py +++ b/ax/analysis/healthcheck/tests/test_can_generate_candidates.py @@ -38,7 +38,7 @@ def test_passes_if_can_generate(self) -> None: ) self.assertEqual(card.get_status(), HealthcheckStatus.PASS) self.assertDictEqual( - card.get_aditional_attrs(), + card.get_additional_attrs(), { "status": HealthcheckStatus.PASS, "reason": "No problems found.", @@ -73,7 +73,7 @@ def test_warns_if_a_trial_was_recently_run(self) -> None: ) self.assertEqual(card.get_status(), HealthcheckStatus.INFO) self.assertDictEqual( - card.get_aditional_attrs(), + card.get_additional_attrs(), { "status": HealthcheckStatus.INFO, "reason": "The data is borked.", @@ -106,7 +106,7 @@ def test_is_fail_no_trials_have_been_run(self) -> None: ) self.assertEqual(card.get_status(), HealthcheckStatus.FAIL) self.assertDictEqual( - card.get_aditional_attrs(), + card.get_additional_attrs(), { "status": HealthcheckStatus.FAIL, "reason": "The data is gone.", @@ -143,7 +143,7 @@ def test_is_fail_if_no_trial_was_recently_run(self) -> None: ) self.assertEqual(card.get_status(), HealthcheckStatus.FAIL) self.assertDictEqual( - card.get_aditional_attrs(), + card.get_additional_attrs(), { "status": HealthcheckStatus.FAIL, "reason": "The data is old.", diff --git a/ax/analysis/healthcheck/tests/test_complexity_rating.py b/ax/analysis/healthcheck/tests/test_complexity_rating.py index a22422153cb..e715f0d20f7 100644 --- a/ax/analysis/healthcheck/tests/test_complexity_rating.py +++ b/ax/analysis/healthcheck/tests/test_complexity_rating.py @@ -61,7 +61,7 @@ def test_standard_configuration(self) -> None: self.assertTrue(card.is_passing()) self.assertEqual(card.get_status(), HealthcheckStatus.PASS) self.assertIn("Standard", card.subtitle) - self.assertEqual(card.get_aditional_attrs()["tier"], "Standard") + self.assertEqual(card.get_additional_attrs()["tier"], "Standard") def test_parameter_counts(self) -> None: test_cases = [ @@ -88,7 +88,7 @@ def test_parameter_counts(self) -> None: self.assertEqual(card.get_status(), expected_status) self.assertIn(expected_tier, card.subtitle) self.assertIn(expected_msg, card.subtitle) - self.assertEqual(card.get_aditional_attrs()["tier"], expected_tier) + self.assertEqual(card.get_additional_attrs()["tier"], expected_tier) def test_objectives_count(self) -> None: test_cases = [