From 0e36286060af3b39db32cd58284ab556dae510be Mon Sep 17 00:00:00 2001 From: Daniel Wong Date: Wed, 22 Feb 2023 18:13:04 -0500 Subject: [PATCH] Pin fmt version at 8.0.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change build script to pin fmt version at same version that folly uses to minimize future breaks. _Context:_ OSS build broke between 3-5 Jan 2023, likely due to changes in folly. While switching to v9.1.0 or 9.0.0 fixes the issue at hand, it seems sensible to match folly, which specifies fmt v8.0.1: https://github.com/facebook/folly/blob/main/build/fbcode_builder/manifests/fmt Changed it on a fresh clone of CacheLib and got it to build. (Also had to change `external_git_branch=dev` for zstd to deal with the cmake/zstd issue in #194, but that should resolve when gets merged into release) > #62 @agordon: For the other packages, you'll notice we do use a specific git tag or branch… I notice `fmt` is an exception - not pinned to a specific git tag or revision - likely an omission that can be fixed. Related CacheLib issues: #186, #189, #107, #97, #62 Related CacheLib commit: 67cc11ad6f5fb7b1e1948513292ef00edee34f5e Last working (Jan 3): https://github.com/facebook/CacheLib/actions/runs/3826992478 First failed (Jan 5): https://github.com/facebook/CacheLib/actions/runs/3844002307/jobs/6546742348 ```error: static assertion failed: Cannot format an argument. To make type T formattable provide a formatter specialization: https://fmt.dev/latest/api.html#udt``` --- contrib/build-package.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/build-package.sh b/contrib/build-package.sh index ff487967c..6e7acac5c 100755 --- a/contrib/build-package.sh +++ b/contrib/build-package.sh @@ -160,6 +160,7 @@ case "$1" in REPODIR=cachelib/external/$NAME SRCDIR=$REPODIR external_git_clone=yes + external_git_tag="8.0.1" cmake_custom_params="-DBUILD_SHARED_LIBS=ON" if test "$build_tests" = "yes" ; then cmake_custom_params="$cmake_custom_params -DFMT_TEST=YES"