feat: change landing page hero #1290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for munseo-preview ready! Built with commit 15fbbed |
|
Deploy preview for docusaurus-preview ready! Built with commit 15fbbed |
This comment has been minimized.
This comment has been minimized.
yangshun
commented
Mar 21, 2019
v1/website/static/css/custom.css
Outdated
| @@ -63,8 +63,8 @@ table td:first-child > code { | |||
| color: #fff; | |||
| font-weight: bold; | |||
| font-size: 24px; | |||
| margin-top: -40px; | |||
There was a problem hiding this comment.
@endiliey I needed this to be there because the mainContainer has a padding of 40px. I was wondering why it appeared there even though I removed it before committing 😞
Without this line, there's a white bar below the announcement.
EDIT: I see that you tried to move it out of the mainContainer but I think it doesn't totally fix the issue.
There was a problem hiding this comment.
Seems that it displays differently on different browser/ resolution. Doesn’t appear in my browser 😂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Make the landing page a bit nicer so that it looks more presentable during F8.
There's the announcement changes in this PR as well as they're on the same branch, please ignore those parts when reviewing this.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Related PRs
(If this PR adds or changes functionality, please take some time to update the docs at https://github.com/facebook/docusaurus, and link to your PR here.)