PSR-0 Compatibility #4

Closed
rdohms opened this Issue Jan 23, 2013 · 8 comments

Projects

None yet

6 participants

@rdohms

Would be great if this would follow PSR-0 folder/namespace structure.

https://github.com/php-fig/fig-standards/blob/master/accepted/PSR-0.md

@wez

when you clone it you get FBMock/Mock.php which defines FBMock_Mock, which seems spiritually compatible to me.

We don't use namespace syntax at FB and we wanted to avoid having to do source transformations as part of our release to github; that would suck in terms of releasing code and taking contributions back.

with that in mind, what specifically would you suggest that we change to improve PSR-0 compatibility?

@rdohms

@wez Using Namespaces or not, PSR-0 defines that "_" represent folders. It was designed for old code with no namespaces as well. So then you would get a FBMock folder with a Mock.php file and etc..

Its just organizational, helps with autoload but Composer already takes care of that.

@elynde
@rtuin

Sure, that would be redundant in some cases.

However, I believe that it is best to have the library repository comply to PSR-0 out-of-the-box. Rather than having those who care (a lot of devs) install the library in their applications and explicitly make sure it complies to PSR-0.

@elynde let me know if this is a standard FBMock wants to comply to, and i'll file a pull request for it.

@elynde

So we would basically just move all of the code into a folder called FBMock?

@facebook-github-bot-8

Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed.

@facebook-github-bot-7

Thank you for your patience. After 30 days with no updates from the core team, we're closing out the issue. If you're still experiencing the problem described, please reopen the issue - thanks!

@rdohms

So the core team ignores the issue and a bot assigns it to "closed" ... sounds legit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment