Composer support #3

Merged
merged 2 commits into from Jan 30, 2013

Conversation

Projects
None yet
2 participants
@rdohms
Contributor

rdohms commented Jan 23, 2013

Adjusted the autoloading to use your autoloader.
Added more info on the package.
Added README instructions
Added php 5.4 constraint

Steps needed from Facebook
This package still needs to be added to Packagist, for this please visit: https://packagist.org/packages/submit
Create an account and add this repo's address, the rest is all good. I do recommend that you tag a stable release once its ready, right now the package is flagged as dev

rdohms added some commits Jan 23, 2013

Finalizing Composer Support
Fixed autoloading and added more details.
Extra details for Composer
Added PHP 5.4 restriction
Added instruction on Composer install
@elynde

This comment has been minimized.

Show comment Hide comment
@elynde

elynde Jan 25, 2013

Contributor

Ok to merge now?

Contributor

elynde commented Jan 25, 2013

Ok to merge now?

@rdohms

This comment has been minimized.

Show comment Hide comment
@rdohms

rdohms Jan 27, 2013

Contributor

@elynde Yep, go for it. Remember to follow the extra steps to add it to Packagist, or it will not work.

Contributor

rdohms commented Jan 27, 2013

@elynde Yep, go for it. Remember to follow the extra steps to add it to Packagist, or it will not work.

elynde added a commit that referenced this pull request Jan 30, 2013

@elynde elynde merged commit 049a536 into facebook:master Jan 30, 2013

@rdohms

This comment has been minimized.

Show comment Hide comment
@rdohms

rdohms Jan 30, 2013

Contributor

@elynde don't forget to register it on Packagist, or it won't work.

Contributor

rdohms commented Jan 30, 2013

@elynde don't forget to register it on Packagist, or it won't work.

@elynde

This comment has been minimized.

Show comment Hide comment
@elynde

elynde Jan 30, 2013

Contributor

Thanks, added it here https://packagist.org/packages/facebook/fbmock, looks like it's working.

Have you used FBMock at all in your projects? Try it out and let me know what you think!

Contributor

elynde commented Jan 30, 2013

Thanks, added it here https://packagist.org/packages/facebook/fbmock, looks like it's working.

Have you used FBMock at all in your projects? Try it out and let me know what you think!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment