Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore reserved characters in quick select mode LABELS #419

Merged
merged 2 commits into from Jun 19, 2022

Conversation

cibinmathew
Copy link
Contributor

@cibinmathew cibinmathew commented Mar 21, 2022

Fixes #410

Reserved
A: toggle selection for all
F: toggle selection for current row

@facebook-github-bot
Copy link

Hi @cibinmathew!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@cibinmathew cibinmathew changed the title Fixes reserved characters in quick select mode LABELS Ignore reserved characters in quick select mode LABELS Mar 21, 2022
@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@KapJI
Copy link
Member

KapJI commented Jun 19, 2022

Thanks!

@KapJI KapJI merged commit 392a415 into facebook:main Jun 19, 2022
@KapJI KapJI mentioned this pull request Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip the F key in quick select mode
3 participants