Remove assert from send #54

Closed
mxcl opened this Issue Oct 3, 2012 · 4 comments

6 participants

@mxcl

My program just crashed because the websocket was unexpectedly closed. This is a debug build, but it seems like (as a consumer of your library) I'd rather have the delegate called with an error message, under debug and release mode.

Will provide pull request if you will accept it and tell me what error handling you want instead.

@cerupcat

+1

@dfed

@mikelikespie, thoughts on this? I'm a pretty big proponent of not asserting unless the world is on 🔥.

@nlutsenko nlutsenko self-assigned this Jun 21, 2016
@nlutsenko nlutsenko closed this in #416 Jun 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment