New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support public key pinning #304

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@tang3w

tang3w commented Oct 29, 2015

This pull request implement the public key SSL pinning for SocketRocket.

@tang3w

This comment has been minimized.

Show comment
Hide comment
@tang3w

tang3w Oct 29, 2015

It seems that the Xcode version for CI is less than 7.0?

The added code depends on macros in Xcode 7. Would you please upgrade Xcode 7.0 or later?

tang3w commented Oct 29, 2015

It seems that the Xcode version for CI is less than 7.0?

The added code depends on macros in Xcode 7. Would you please upgrade Xcode 7.0 or later?

@dfed

This comment has been minimized.

Show comment
Hide comment
@dfed

dfed Oct 30, 2015

Contributor

Our CI version is set to older versions since we don't want to break them. That said, we're currently looking into adopting pinning with #274

Contributor

dfed commented Oct 30, 2015

Our CI version is set to older versions since we don't want to break them. That said, we're currently looking into adopting pinning with #274

@dfed dfed closed this Oct 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment