change location of headers for iOS static lib target #74

Closed
wants to merge 1 commit into
from

3 participants

@pizthewiz

loosen the requirement that an application/super-project must reference the subproject headers explicitly through the source tree; also avoids copying the headers at application archive time; see jamie montgomerie’s explanation here: http://www.blog.montgomerie.net/easy-xcode-static-library-subprojects-and-submodules

i should also mention, the PR should not require existing iOS SocketRocket clients to change how headers are referenced (as one could always use headers from the project source tree itself), but makes the headers available in a framework style #import much like one would find on Mac OS X after a header search path tweak.

@pizthewiz pizthewiz loosen requirement that an application/super-project must reference t…
…he subproject headers explicitly through the source tree; also avoids copying the headers at application archive time; see jamie montgomerie’s explanation here: http://www.blog.montgomerie.net/easy-xcode-static-library-subprojects-and-submodules
ad6656f
@efirestone efirestone commented on the diff Sep 18, 2015
SocketRocket.xcodeproj/project.pbxproj
@@ -705,6 +703,7 @@
);
OTHER_LDFLAGS = "-ObjC";
PRODUCT_NAME = "$(TARGET_NAME)";
+ PUBLIC_HEADERS_FOLDER_PATH = include/$PRODUCT_NAME;
@efirestone
efirestone added a line comment Sep 18, 2015

nit: The "standard" way to write this (as defined by those created by Xcode) is using parentheses: $(PRODUCT_NAME). Not a blocker though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@efirestone

Looks good after resolving conflicts.

@dfed

Closing this out since we duplicated this #292

@dfed dfed closed this Oct 3, 2015
@jessearmand jessearmand added a commit to jessearmand/SocketRocket that referenced this pull request Oct 6, 2015
@jessearmand jessearmand Merge remote-tracking branch 'origin/master'
* origin/master: (26 commits)
  cherry picking facebook#74 and fixing merge conflicts
  Fix Autobahn link in README
  Make chatroom.go pass golint and gofmt
  Added ability to provide cookies for the web socket connection
  Update gitignore
  Update gitconfig
  Bump pod version to 0.4.1
  Remove _ from _openConnection and _closeConnection. #263
  Make SRWebSocket.h public
  CI should validate the pod spec
  Remove unnecessary run script
  Update version number to 0.4
  In iOS 9 / El Cap, NSTimer enforces non-nullability of target/action.
  Do not use Apple method names _connect and _disconnect
  Update podspec
  Add Travis CI
  Update .gitignore
  Move to XCTest
  Suppress OCUnit warnings in Xcode 6.4
  Fix 64 bit build error
  ...
3baaaa8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment